Async test result by Phuong-Le-NN · Pull Request #549 · nickbar01234/codebuddy

Phuong-Le-NN · 2025-11-26T22:38:02Z

Description

Async test result when one buddy click Run button of Leetcode

Screenshots

Test

Click Run code on one buddy and wait a bit to see the Test Result tab filled out on the other.

Checklist

If you're making changes to the extension, please run through the following checklist to make sure that we don't have
any regressions. Note that we plan to add integration tests in the future!

Create room and join room on at least 2 browsers
Ensure that code and tests are correctly stream
Verify that when reloading, user can automatically join the room

Possible Downsides

Additional Documentations

extension/src/utils/messages.ts

extension/src/utils/string.ts

extension/src/types/index.ts

extension/src/components/panel/editor/tab/TestResultTab.tsx

…un test cases

changed type to reuse test case assignment interface fix for case when input has no variable name

…st result cases yet

backend working? frontend not yet for error cases

… backend compplete

…object for each error case

fix + refactor slightly on backend for grouping test result

nickbar01234 · 2026-03-16T15:47:01Z

extension/src/assets/accepted_icon.png

Can we use luicide-react for the icons?

nickbar01234 · 2026-03-16T21:30:41Z

extension/src/entrypoints/content.tsx

+    s.src = chrome.runtime.getURL("proxy.js");
+    s.type = "text/javascript";
+    s.onload = () => s.remove();
+    document.documentElement.appendChild(s);


can you clarify what this is for?

nickbar01234 · 2026-03-16T21:32:16Z

extension/src/entrypoints/router.ts

+        const regexTestResult =
+          /^https:\/\/leetcode\.com\/submissions\/detail\/runcode_[^/]+\/check\/$/;
+
+        if (typeof res.url === "string" && regexTestResult.test(res.url)) {


Suggested change

if (typeof res.url === "string" && regexTestResult.test(res.url)) {

if (regexTestResult.test(res.url)) {

nickbar01234 · 2026-03-16T21:47:56Z

extension/src/entrypoints/router.ts

+
+    const origFetch = window.fetch;
+
+    window.fetch = async (...args) => {


nickbar01234 · 2026-03-16T21:49:30Z

extension/src/entrypoints/router.ts

+                  {
+                    source: "LC_HOOK",
+                    url: res.url,
+                    data: data,
+                    type: "LC_HOOK",
+                  },


Worth adding a new type here https://github.com/nickbar01234/codebuddy/blob/main/extension/src/types/window.ts.

In https://github.com/nickbar01234/codebuddy/pull/549/changes#diff-e34ae516552cad6954a715c3177eb0e99778fa92ad88556a1d574eb9d88014a0R167-R174, we can do a strongly typed handler

const messageHandler = async (event: MessageEvent<LeetCodeHook>) => {

nit: LC_SUBMISSION_RESULT instead of LC_HOOK?

nickbar01234 · 2026-03-17T02:02:59Z

Can you comment with the latest screenshot of the new UI?

nickbar01234 · 2026-03-17T02:11:32Z

extension/src/utils/messages.ts


+export const getTestResultsPayload = (
+  variables: Question["variables"] | undefined,
+  testResults?: any


This can be strongly typed right

May be without ? too

nickbar01234 · 2026-03-17T14:44:28Z

extension/src/components/panel/editor/EditorPanel.tsx

+      {
+        value: "testResult",
+        label: "Test Result",
+        Icon: FlaskConical,


Can we change the icon to https://lucide.dev/icons/terminal

nickbar01234 · 2026-03-17T14:48:42Z

extension/src/components/panel/editor/tab/TestResultTab.tsx

+                const passed = (test.testResult ?? []).every(
+                  (r: ResultAssignment) => r.output === r.expected
+                );
+                const selected = !!test.selected;


This is not necessary right?

nickbar01234 · 2026-03-17T14:49:39Z

extension/src/components/panel/editor/tab/TestResultTab.tsx

+                return (
+                  <div key={idx} onClick={() => selectTestResult(idx)}>
+                    <button
+                      className={`${baseClasses} ${selected ? selectedClasses : unselectedClasses} gap-2`}


Suggested change

className={`${baseClasses} ${selected ? selectedClasses : unselectedClasses} gap-2`}

className={cn(baseClasses, { selectedClasses: selected, unselectedClasses: !selected )}

nickbar01234 · 2026-03-17T15:00:04Z

extension/src/components/panel/editor/tab/testResultComponents/sharedComponents.tsx

+  inputs: { variable?: string; value: string }[];
+}
+
+export const InputDisplay: React.FC<InputDisplayProps> = ({ inputs }) => (


Haven't looked through all the css yet but let's make sure the styles match with TestTab

nickbar01234 · 2026-03-17T15:01:57Z

extension/src/components/panel/editor/tab/testResultComponents/CompileErrorResult.tsx

@@ -0,0 +1,13 @@
+import React from "react";


I would rename testResultComponents to TestResults

nickbar01234 · 2026-03-17T15:02:26Z

extension/src/components/panel/editor/tab/testResultComponents/sharedComponents.tsx

@@ -0,0 +1,112 @@
+import { SelectableTestResult } from "@cb/types";


maybe sharedComponents.tsx as base.tsx?

nickbar01234 · 2026-03-17T15:08:42Z

extension/src/constants/index.ts

+export const TEST_RESULT_ERROR = {
+  "Runtime Error": "full_runtime_error",
+  "Compile Error": "full_compile_error",
+  "Invalid Test Case": "full_runtime_error",


should we consolidate the constant here with https://github.com/nickbar01234/codebuddy/pull/549/changes#diff-ad1d6f906f1d151b1f3d7a34cc0286a0b2520920a2f9059638c878cac7c55911R3-R10?

nickbar01234 · 2026-03-17T15:09:31Z

extension/src/types/index.ts

 }

+export interface TestResult {
+  testResultStatus: string;


type is union of all keys https://github.com/nickbar01234/codebuddy/pull/549/changes#diff-d9cc01c7b64c1e15627e55b2ebfefe0f214fe3306afb06537b1f1478bc6ffdd4R116 and unknown for cases we don't handle yet

nickbar01234 · 2026-03-17T15:15:17Z

extension/src/utils/messages.ts

+      testResults.code_answer?.slice(0, -1),
+      testResults.expected_code_answer?.slice(0, -1),


can you clarify why we exclude last idx

nickbar01234 · 2026-03-17T15:25:13Z

extension/src/utils/string.ts

+
+  const getLastRunIndex = () =>
+    codeAnswer.findIndex((val) => val !== "0") === -1
+      ? codeAnswer.length


wouldn't this be out of bound? Also we throw away some work with 2 findIndex

nickbar01234 · 2026-03-17T15:26:38Z

extension/src/utils/string.ts

+  const getFirstInput = () => {
+    if (numCases === 0) return [];
+    const firstTest = testInputs[0];
+    if (firstTest.test.length !== varCount) return [];


Instead of multiple checks throughout the function, how do you feel about doing all these checks upfront and returning empty list otherwise? It just makes the code easier to read if we focus only on the logic

nickbar01234 · 2026-03-17T15:34:26Z

extension/src/utils/messages.ts

+  }
+
+  // Because statusMessage of invalid test case is the same as runtime error although they are handled differently
+  const statusMsg: string = testResults.invalid_testcase


A bit confuse why we need both statusMsg and https://github.com/nickbar01234/codebuddy/pull/549/changes#diff-69f1956d4fa6ee2face76261231445546a6bc5bcc1d528c82300843c32cd1cfdR48-R52

nickbar01234 · 2026-03-17T15:35:51Z

extension/src/utils/messages.ts


+export const getTestResultsPayload = (
+  variables: Question["variables"] | undefined,
+  testResults?: any


would you be able to paste a couple examples of what testResults is for each of the cases you're targeting?

nickbar01234 · 2026-03-17T15:47:14Z

extension/src/utils/string.ts

+  );
+  const overallStatus = allMatch ? "Accepted" : "Wrong Answer";
+
+  // Only loop for Accepted cases


this loops for everything though right

nickbar01234 · 2026-03-17T15:48:57Z

extension/src/utils/string.ts

+    });
+  }
+
+  return results.length > 0 ? results : [{ testResultStatus, testResult: [] }];


we should always be able to return just results?

nickbar01234 · 2026-03-17T15:50:22Z

extension/src/components/panel/editor/tab/TestResultTab.tsx

+  };
+
+  return (
+    <SkeletonWrapper loading={false} className="relative">


Can we wrap this in error boundary? https://react.dev/reference/react/Component#catching-rendering-errors-with-an-error-boundary. Reasoning is that this feature is quite complex with a lot of array indexing and handling, so we don't want to break other working components

nickbar01234 · 2026-03-17T15:56:36Z

extension/src/types/index.ts

+
 export type TestCases = TestCase[];

+export type TestResults = TestResult[];


hmm, the use of TestResults is a bit inconsistent. In https://github.com/nickbar01234/codebuddy/pull/549/changes#diff-a6c0609a405d5d0726edb4d54dd9ddaab92ce2a9c7224a405da9e0bda60b5d61R32, runtime errors return 1-item list. For cases where we run the tests, the length matches the number of test input, with each TestResult.testResult being 1 element.

It looks to me like we actually just need TestResult to capture everything

Phuong-Le-NN marked this pull request as ready for review November 29, 2025 19:29

nickbar01234 reviewed Nov 30, 2025

View reviewed changes

extension/src/utils/messages.ts Outdated Show resolved Hide resolved

nickbar01234 reviewed Nov 30, 2025

View reviewed changes

extension/src/utils/string.ts Outdated Show resolved Hide resolved

nickbar01234 reviewed Nov 30, 2025

View reviewed changes

extension/src/types/index.ts Outdated Show resolved Hide resolved

nickbar01234 reviewed Nov 30, 2025

View reviewed changes

extension/src/components/panel/editor/tab/TestResultTab.tsx Outdated Show resolved Hide resolved

Phuong-Le-NN force-pushed the async_test_res_2 branch from 31de9a6 to 362196a Compare February 14, 2026 20:48

PhuongLe added 10 commits March 16, 2026 11:40

able to synce test result by intercepting fetch request after buddy r…

3937ba8

…un test cases

commit to keep progress

4faf254

changed type to reuse test case assignment interface fix for case when input has no variable name

not breaking non error test result cases but not working for error te…

17bfa54

…st result cases yet

commit to keep progress

0b6d129

backend working? frontend not yet for error cases

commit to keep progress before starting on frontend, test result from…

522ce3c

… backend compplete

frontend in progress

d6855b4

frontend almost complete + fixed backend a little t send the correct …

eb4050a

…object for each error case

completed and cleaned up on frontend

5a3e583

fix + refactor slightly on backend for grouping test result

clean up and add comments

80f2dab

add icon and fixed minor ui

dfac775

nickbar01234 force-pushed the async_test_res_2 branch from 395c6e4 to dfac775 Compare March 16, 2026 15:40

nickbar01234 reviewed Mar 16, 2026

View reviewed changes

extension/src/assets/accepted_icon.png

Copy link

Owner

nickbar01234 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use luicide-react for the icons?

nickbar01234 reviewed Mar 16, 2026

View reviewed changes

extension/src/entrypoints/router.ts

const origFetch = window.fetch;

window.fetch = async (...args) => {

Copy link

Owner

nickbar01234 Mar 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

nickbar01234 reviewed Mar 16, 2026

View reviewed changes

nickbar01234 reviewed Mar 17, 2026

View reviewed changes

	if (typeof res.url === "string" && regexTestResult.test(res.url)) {
	if (regexTestResult.test(res.url)) {


		const origFetch = window.fetch;

		window.fetch = async (...args) => {

	className={`${baseClasses} ${selected ? selectedClasses : unselectedClasses} gap-2`}
	className={cn(baseClasses, { selectedClasses: selected, unselectedClasses: !selected )}

		@@ -0,0 +1,112 @@
		import { SelectableTestResult } from "@cb/types";

		testResults.code_answer?.slice(0, -1),
		testResults.expected_code_answer?.slice(0, -1),


		export type TestCases = TestCase[];

		export type TestResults = TestResult[];

Conversation

Phuong-Le-NN commented Nov 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Screenshots

Test

Checklist

Possible Downsides

Additional Documentations

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nickbar01234 commented Mar 17, 2026

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Phuong-Le-NN commented Nov 26, 2025 •

edited

Loading